Skip to content

refactor(IDynamicObject): remove SupportComplexProperty parameter #5252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2025
Merged

refactor(IDynamicObject): remove SupportComplexProperty parameter #5252

merged 2 commits into from
Jan 31, 2025

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jan 31, 2025 •
edited by sourcery-ai bot
Loading

remove SupportComplexProperty parameter

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符；如果有关联 Issue 请在下方填写相关编号

Description

fixes #5251

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Fix an issue where complex properties were not supported when setting property values.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 31, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request removes the supportComplexProperty parameter from the GetPropertyValue and SetPropertyValue methods in Utility and CacheManager. The logic for handling complex properties is now determined by checking if the property name contains a period and if the model is a dynamic object.

Class diagram showing the refactored property access methods

classDiagram
    class Utility {
        +GetPropertyValue<TModel, TResult>(model: TModel, fieldName: string) TResult
        +GetPropertyValue(model: object, fieldName: string) object?
        +SetPropertyValue<TModel, TValue>(model: TModel, fieldName: string, value: TValue) void
    }

    class CacheManager {
        +GetPropertyValue<TModel, TResult>(model: TModel, fieldName: string) TResult
        -GetValue<TModel, TResult>(model: TModel, fieldName: string) TResult
        +SetPropertyValue<TModel, TValue>(model: TModel, fieldName: TValue, value: TValue) void
    }

    class LambdaExtensions {
        +GetPropertyValueLambda<TModel, TResult>(model: TModel, propertyName: string) Expression
        +SetPropertyValueLambda<TModel, TValue>(model: TModel, propertyName: string) Expression
    }

    Utility ..> CacheManager: uses
    CacheManager ..> LambdaExtensions: uses

    note for LambdaExtensions "Complex property handling
now based on property name
and dynamic assembly check"
Loading

Flow diagram for property value access logic

flowchart TD
    A[Get/Set Property Value] --> B{Is Dynamic Object?}
    B -->|Yes| C[Use Dynamic Object Handler]
    B -->|No| D{Contains '.' in property name?}
    D -->|Yes| E[Use Complex Property Handler]
    D -->|No| F[Use Simple Property Handler]

    note[The supportComplexProperty parameter
has been removed and logic is now
based on property name and object type]
Loading

File-Level Changes

Change Details Files
Removed the supportComplexProperty parameter from GetPropertyValue and SetPropertyValue methods.
  • Removed the supportComplexProperty parameter from the GetPropertyValue and SetPropertyValue methods in Utility.
  • Removed the supportComplexProperty parameter from the GetPropertyValue and SetPropertyValue methods in CacheManager.
  • Removed the supportComplexProperty parameter from the GetPropertyValueLambda and SetPropertyValueLambda methods in LambdaExtensions.
  • Removed the supportComplexProperty parameter from the calls to SetPropertyValue in DataTableDynamicContext.
  • Removed the supportComplexProperty parameter from the calls to GetPropertyValue in DataTableDynamicObject.
  • Removed the supportComplexProperty parameter from the calls to GetPropertyValue and SetPropertyValue in DynamicObject.
 src/BootstrapBlazor/Utils/Utility.cs
src/BootstrapBlazor/Services/CacheManager.cs
src/BootstrapBlazor/Extensions/LambdaExtensions.cs
src/BootstrapBlazor/Dynamic/DataTableDynamicContext.cs
src/BootstrapBlazor/Dynamic/DataTableDynamicObject.cs
src/BootstrapBlazor/Dynamic/DynamicObject.cs
Modified the logic for handling complex properties.
  • The logic for handling complex properties is now determined by checking if the property name contains a period and if the model is a dynamic object.
  • The LambdaInvoke method in Utility.cs was removed and the logic was moved to GetPropertyValue.
  • The cache key in CacheManager.cs no longer includes the supportComplexProperty parameter.
 src/BootstrapBlazor/Utils/Utility.cs
src/BootstrapBlazor/Services/CacheManager.cs
src/BootstrapBlazor/Extensions/LambdaExtensions.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#5251 Remove SupportComplexProperty parameter from methods ✅
#5251 Use Assembly.IsDynamic check instead of SupportComplexProperty parameter ✅

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Jan 31, 2025
@bb-auto bb-auto bot added this to the v9.3.0 milestone Jan 31, 2025
@ArgoZhang ArgoZhang enabled auto-merge (squash) January 31, 2025 03:10
sourcery-ai[bot]
sourcery-ai bot approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Jan 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a8b3118) to head (3f1d383).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #5252   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          639       639           
  Lines        28732     28733    +1     
  Branches      4080      4080           
=========================================
+ Hits         28732     28733    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit ae7a53c into main Jan 31, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the refactor-tablecolumn branch January 31, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] approved these changes

Assignees

@ArgoZhang ArgoZhang

Labels

enhancement New feature or request

Projects

None yet

Milestone

v9.3.0

Development

Successfully merging this pull request may close these issues.

refactor(IDynamicObject): remove SupportComplexProperty parameter

2 participants

@ArgoZhang